Support managing multiple data partitions for Train/Val/Test in controller#48
Conversation
Support storage unit in TransferQueue
* Support controller in TransferQueue * Fix import * Fix comments --------- Co-authored-by: liuximeng <13073314+liuximeng18772102439@user.noreply.gitee.com>
Added copyright and licensing information to the controller.py file.
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
* update client docstring Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> * fix n_sample related problems Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> --------- Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
* Add metadata.py and test_simple_storage_unit.py * Add copyright and license information to test_simple_storage_unit.py * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Han Zhenyu 韩振宇 <o0shower0o@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: liuximeng <13073314+liuximeng18772102439@user.noreply.gitee.com>
…artitions for Train/Val/Test in controller (#45) Co-authored-by: liuximeng <13073314+liuximeng18772102439@user.noreply.gitee.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
|
Caution Review failedThe pull request is closed. WalkthroughThis PR refactors the TransferQueue integration to consolidate multi-role train/val clients into a unified single-controller approach. Method signatures across agent_loop, worker, and utils modules are updated to accept Changes
Sequence Diagram(s)sequenceDiagram
participant Trainer as RayPPOTrainer
participant Controller as TransferQueueController
participant Client as AsyncTransferQueueClient
participant Storage as AsyncSimpleStorageManager
Trainer->>Trainer: _initialize_data_system()
Trainer->>Controller: Initialize (unified, single controller)
Trainer->>Client: create_transferqueue_client(controller_info, config)
Client->>Storage: initialize_storage_manager(config)
Trainer->>Client: async_put(partition_id="train_X", data)
Client->>Storage: Store at partition_id
Trainer->>Client: async_get_meta(partition_id="train_X")
Client->>Storage: Retrieve metadata
Trainer->>Client: async_get_data(partition_id="train_X")
Client->>Storage: Retrieve data
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Documentation
Refactor
Chores